Resolve autocorrect deprecations #378
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this get merged, anything I can do to help? |
Closes Shopify#368 This is pretty much just a compatibility layer in itself. Cops here are still declared with the old style (`autocorrect` instance method for example) but rewriting that all is not trivial and also works just fine
etiennebarrie
force-pushed
the
autocorrect-deprecations
branch
from
7fddf50 to
733c51d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds in top of #377, just the last commit is specific to this branch.
Closes #368
This is pretty much just a compatibility layer in itself.
Cops here are still declared with the old style (
autocorrectinstance method for example)but rewriting that all is not trivial and also works just fine