Rethrow functions esbuild errors #5231
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 17, 2025
Coverage report
Test suite run success2004 tests passing in 905 suites. Report generated by 🧪jest coverage report action from a1b5698 |
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
isaacroldan
force-pushed
the
01-17-rethrow_functions_esbuild_errors
branch
from
23d656e to
a1b5698
Compare
Comment on lines
+191
to
+193
| const errors = error.errors ?? [] | ||
| // If there is an `errors` array, it's an esbuild error, re-throw it directly. | ||
| if (errors.length) throw error |
There was a problem hiding this comment.
since we never use errors again
Suggested change
| const errors = error.errors ?? [] | |
| // If there is an `errors` array, it's an esbuild error, re-throw it directly. | |
| if (errors.length) throw error | |
| // If there is an `errors` array, it's an esbuild error, re-throw it directly. | |
| if (error.errors?.length) throw error |
alexanderMontague
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We want ESBuild errors from functions to appear in the dev logs.
WHAT is this pull request doing?
If a javascript function throws an ESBuild error, re-throw as it is and the dev-session will automatically parse and format it.
How to test your changes?
Measuring impact
Checklist