Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render error page on theme asset upload error #5221

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jamesmengo
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

jamesmengo commented Jan 16, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.23% (-0.02% 🔻)
8871/11792
🟡 Branches
70.42% (-0.02% 🔻)
4325/6142
🟡 Functions
75.03% (-0.02% 🔻)
2323/3096
🟡 Lines
75.79% (-0.02% 🔻)
8387/11066
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

2000 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from d7665cd

@jamesmengo jamesmengo force-pushed the jm/store_asset_upload_failures branch from 550b4c6 to 6edd52f Compare January 16, 2025 20:25
@jamesmengo jamesmengo force-pushed the jm/render_error_page branch from 7ef0845 to 7152c71 Compare January 16, 2025 20:27
@jamesmengo jamesmengo force-pushed the jm/store_asset_upload_failures branch from 6edd52f to dd17d8a Compare January 16, 2025 23:31
@jamesmengo jamesmengo force-pushed the jm/render_error_page branch from 7152c71 to d7665cd Compare January 16, 2025 23:32
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/themes/types.d.ts
@@ -92,6 +92,10 @@ export interface ThemeFileSystem extends VirtualFileSystem {
     applyIgnoreFilters: <T extends {
         key: string;
     }>(files: T[]) => T[];
+    /**
+     * Stores upload errors returned when uploading files via the Asset API
+     */
+    uploadErrors: Map<Key, string[]>;
 }
 /**
  * Represents a theme on the file system.

@jamesmengo jamesmengo force-pushed the jm/store_asset_upload_failures branch from dd17d8a to 7e34195 Compare January 16, 2025 23:58
Base automatically changed from jm/store_asset_upload_failures to main January 17, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant