Make tophatting templates changes possible #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just pass `SHOPIFY_APP_TEMPLATES_JSON_PATH=/path/to/your/file` and it will draw from there instead of pulling from the live URL.
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1994 tests passing in 900 suites. Report generated by 🧪jest coverage report action from a8e7cd9 |
amcaplan
force-pushed
the
make-tophatting-templates-changes-possible
branch
from
88f17c6 to
8690d6e
Compare
amcaplan
force-pushed
the
make-tophatting-templates-changes-possible
branch
from
8690d6e to
762cd7b
Compare
shauns
approved these changes
Dec 20, 2024
|
|
||
| const TEMPLATE_JSON_URL = 'https://cdn.shopify.com/static/cli/extensions/templates.json' | ||
| const TEMPLATE_PATH_ENV_VARIABLE = 'SHOPIFY_APP_TEMPLATES_JSON_PATH' |
There was a problem hiding this comment.
Let's put this in app/src/cli/constants.ts -- there's a handful of other app-specific environment variables there.
There was a problem hiding this comment.
I debated about this point - it's kind of a little debugging hack, but we do have some debugging hacks there as well!
amcaplan
force-pushed
the
make-tophatting-templates-changes-possible
branch
from
bf6e4ea to
a8e7cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We should be able to tophat changes without pushing to prod.
WHAT is this pull request doing?
Makes it possible to pass a filepath and test the changes to templates locally. Run with
SHOPIFY_APP_TEMPLATES_JSON_PATH=/path/to/your/fileand it should work!How to test your changes?
app generate extensionnormally, it should still work!SHOPIFY_APP_TEMPLATES_JSON_PATH=/path/to/your/file p shopify app generate extension --path /path/to/your/appdisplays options that match the fileMeasuring impact
How do we know this change was effective? Please choose one:
Checklist