-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send a list of request ids to monorail #5119
Send a list of request ids to monorail #5119
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1996 tests passing in 900 suites. Report generated by 🧪jest coverage report action from 7d02d54 |
We detected some changes at packages/*/src and there are no updates in the .changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/private/node/request-ids.d.tsexport declare const MAX_REQUEST_IDS = 100;
/**
* Manages collection of request IDs during command execution
*/
declare class RequestIDCollection {
private static instance;
static getInstance(): RequestIDCollection;
private requestIds;
/**
* Add a request ID to the collection
* We only report the first MAX_REQUEST_IDS request IDs.
*/
addRequestId(requestId: string | undefined | null): void;
/**
* Get all collected request IDs
*/
getRequestIds(): string[];
/**
* Clear all stored request IDs
*/
clear(): void;
}
export declare const requestIdsCollection: RequestIDCollection;
export {};
Existing type declarationspackages/cli-kit/dist/public/node/monorail.d.ts@@ -2,7 +2,7 @@ import { JsonMap } from '../../private/common/json.js';
import { DeepRequired } from '../common/ts/deep-required.js';
export { DeepRequired };
type Optional<T> = T | null;
-export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.15";
+export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.16";
export interface Schemas {
[MONORAIL_COMMAND_TOPIC]: {
sensitive: {
|
WHY are these changes introduced?
Enable tracking and reporting of request IDs from GraphQL API calls in analytics events.
WHAT is this pull request doing?
RequestIDCollection
class to manage and store request IDs during command executionHow to test your changes?
--verbose
Measuring impact
How do we know this change was effective? Please choose one:
Checklist