[Bug Fix] Reduce theme upload batch size to prevent timeout

[aswamy]

WHY are these changes introduced?

Part of #5031

WHAT is this pull request doing?

A previous PR changed the endpoint to upload the themes files from REST API to GraphQL API

• The new endpoint did not cause the issue, but the PR also increased the theme upload batch size
• This is generally fine when using the CLI through regular user login, but fails when requests are being proxied through Theme Access App

How to test your changes?

• Instead Theme Access App on your store
• Set environment variables in terminal

export SHOPIFY_CLI_THEME_TOKEN=<password from app>
export SHOPIFY_FLAG_STORE=<store>
export SHOPIFY_FLAG_FORCE="1"

• Run this CLI branch against an existing theme
  • npx shopify theme push --theme="bug-dec16" --unpublished --verbose --path=<path-to-repo>
• theme should be uploaded

NOTE: Also try uploading a LOT of asset files AND with large asset files (e.g. download large images in asset folder)

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	75.26% (+0.02% 🔼)	8802/11696
🟡	Branches	70.58% (+0.04% 🔼)	4288/6075
🟡	Functions	75% (-0.02% 🔻)	2301/3068
🟡	Lines	75.81% (+0.03% 🔼)	8323/10979

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟡	... / context.ts	70.75%	60% (-2.07% 🔻)	73.91%	73.33%
🔴	... / extension.ts	53.85% (-1.71% 🔻)	58.33% (+0.64% 🔼)	50%	54.9% (-1.7% 🔻)
🟢	... / app-event-watcher.ts	93.83% (-1.23% 🔻)	86.49%	90.48%	98.61%
🟢	... / dev-session.ts	85.96% (-1.03% 🔻)	68.33% (+1.09% 🔼)	91.67% (-0.93% 🔻)	92.93% (-0.4% 🔻)
🟢	... / ConcurrentOutput.tsx	98.36% (-1.64% 🔻)	88% (-4% 🔻)	100%	98.33% (-1.67% 🔻)

Test suite run success

1989 tests passing in 898 suites.

Report generated by 🧪jest coverage report action from df9d347

[Waynenabors]

Just to be clear, does this address the theme pull issue from #5094? I'm currently having issues with push and pull.

[graygilmore]

@Waynenabors I wouldn't say with certainty, no. The user that says it's a dupe is not a part of Shopify and may have been guessing.

[jamesmengo]

Could we only change these limits when using the theme access app?

[frandiox]

Thanks for debugging it Alok! Let's ship this for now until we can properly raise the limits 🚀

[frandiox]

Should we add a comment here specifying where is the limit coming from? Or perhaps linking this very PR so the context is not lost?

[aswamy]

Good idea. I will add a comment explaining why we had to lower this limit.

[Waynenabors]

Any idea when this might get in? Our deploys are failing and I'm trying to decide if it's worth finding an alternative. Thanks everyone!

[craigmichaelmartin]

Any idea when this might get in?

Hey @Waynenabors! This is currently released in @shopify/cli@nightly and will be released in a patched version 3.72.2 for @shopify/cli@latest tomorrow.