Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workflows for extensions that have related extensions #5108

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

don't double render success messages

deef527
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Improve workflows for extensions that have related extensions #5108

don't double render success messages
deef527
Select commit
Loading
Failed to load commit list.
GitHub Actions / ESLint Report Analysis failed Dec 13, 2024 in 1s

ESLint Report Analysis

10 ESLint error(s) and 7 ESLint warning(s) found in pull request changed files.

Details

Annotations

Check failure on line 11 in packages/app/src/cli/commands/app/generate/extension.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/commands/app/generate/extension.ts#L11 

[import/order] `../../../services/generate/workflows/registry.js` import should occur before import of `@oclif/core`

Check failure on line 11 in packages/app/src/cli/commands/app/generate/extension.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/commands/app/generate/extension.ts#L11 

[prettier/prettier] Delete `·`

Check warning on line 107 in packages/app/src/cli/prompts/generate/extension.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/prompts/generate/extension.ts#L107 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check failure on line 68 in packages/app/src/cli/services/generate.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate.ts#L68 

[no-warning-comments] Unexpected 'todo' comment: 'TODO: Cleanup extension?'.

Check warning on line 114 in packages/app/src/cli/services/generate.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate.ts#L114 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 176 in packages/app/src/cli/services/generate.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate.ts#L176 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 181 in packages/app/src/cli/services/generate.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate.ts#L181 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 182 in packages/app/src/cli/services/generate.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate.ts#L182 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 86 in packages/app/src/cli/services/generate/extension.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/extension.ts#L86 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check failure on line 177 in packages/app/src/cli/services/generate/extension.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/extension.ts#L177 

[no-warning-comments] Unexpected 'todo' comment: 'TODO: This is where we'd want to write...'.

Check warning on line 185 in packages/app/src/cli/services/generate/extension.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/extension.ts#L185 

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check failure on line 1 in packages/app/src/cli/services/generate/workflows/discount-details-function-settings-collection.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/workflows/discount-details-function-settings-collection.ts#L1 

[import/order] `@shopify/cli-kit/node/ui` import should occur after import of `../../generate.js`

Check failure on line 23 in packages/app/src/cli/services/generate/workflows/discount-details-function-settings-collection.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/workflows/discount-details-function-settings-collection.ts#L23 

[eqeqeq] Expected '===' and instead saw '=='.

Check failure on line 35 in packages/app/src/cli/services/generate/workflows/discount-details-function-settings-collection.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/workflows/discount-details-function-settings-collection.ts#L35 

[@typescript-eslint/no-unused-vars] 'generatedExtension' is assigned a value but never used. Allowed unused vars must match /^_/u.

Check failure on line 33 in packages/app/src/cli/services/generate/workflows/function-with-admin-ui.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/workflows/function-with-admin-ui.ts#L33 

[no-warning-comments] Unexpected 'todo' comment: 'TODO: What if it's larger than the...'.

Check failure on line 20 in packages/app/src/cli/services/generate/workflows/patch-configuration-file.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/workflows/patch-configuration-file.ts#L20 

[@typescript-eslint/no-unnecessary-type-assertion] This assertion is unnecessary since it does not change the type of the expression.

Check failure on line 20 in packages/app/src/cli/services/generate/workflows/patch-configuration-file.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/workflows/patch-configuration-file.ts#L20 

[@typescript-eslint/no-unnecessary-type-assertion] This assertion is unnecessary since it does not change the type of the expression.
View more details on GitHub Actions