-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support migration of product configuration link to cli #5055
Support migration of product configuration link to cli #5055
Conversation
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.71.4";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.71.0";
\ No newline at end of file
packages/cli-kit/dist/public/node/cli.d.ts@@ -16,13 +16,13 @@ interface RunCLIOptions {
*/
export declare function runCLI(options: RunCLIOptions & {
runInCreateMode?: boolean;
-}, launchCLI?: (options: {
+}, launchCLI: (options: {
moduleURL: string;
}) => Promise<void>, argv?: string[], env?: NodeJS.ProcessEnv, versions?: NodeJS.ProcessVersions): Promise<void>;
/**
* A function for create-x CLIs that automatically runs the "init" command.
*/
-export declare function runCreateCLI(options: RunCLIOptions, launchCLI?: (options: {
+export declare function runCreateCLI(options: RunCLIOptions, launchCLI: (options: {
moduleURL: string;
}) => Promise<void>, argv?: string[], env?: NodeJS.ProcessEnv, versions?: NodeJS.ProcessVersions): Promise<void>;
/**
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1975 tests passing in 897 suites. Report generated by 🧪jest coverage report action from bd4383d |
2f2c708
to
732ca78
Compare
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
Closing this PR in favour of the approach described in https://github.com/Shopify/bundles-app/issues/2944 |
WHY are these changes introduced?
Fixes https://github.com/Shopify/bundles-app/issues/2841
WHAT is this pull request doing?
Supports migrating dashboard-managed product configuration link extensions to become CLI managed as part of the dev and deploy commands.
How to test your changes?
Warning
🎩 wont work until https://github.com/Shopify/shopify/pull/558141 and other dependencies are merged
Follow the steps described in #5054 to import product configuration link extensions to CLI. Once imported run
shopify app dev
orshopify app deploy
to migrate the extension to be CLI managed.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist