Remove the "refresh the session when 401 errors happen" #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it will be restored by #5001)
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/cli/api/graphql/admin/generated/theme_files_upsert.d.tsimport * as Types from './types.js';
import { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-node/core';
export type ThemeFilesUpsertMutationVariables = Types.Exact<{
files: Types.OnlineStoreThemeFilesUpsertFileInput[] | Types.OnlineStoreThemeFilesUpsertFileInput;
themeId: Types.Scalars['ID']['input'];
}>;
export type ThemeFilesUpsertMutation = {
themeFilesUpsert?: {
upsertedThemeFiles?: {
filename: string;
}[] | null;
userErrors: {
filename?: string | null;
message: string;
}[];
} | null;
};
export declare const ThemeFilesUpsert: DocumentNode<ThemeFilesUpsertMutation, Types.Exact<{
files: Types.OnlineStoreThemeFilesUpsertFileInput[] | Types.OnlineStoreThemeFilesUpsertFileInput;
themeId: Types.Scalars['ID']['input'];
}>>;
Existing type declarationspackages/cli-kit/dist/public/node/themes/factories.d.ts@@ -1,5 +1,4 @@
-import { AssetParams } from './api.js';
-import { Result, Checksum, Theme, ThemeAsset } from '@shopify/cli-kit/node/themes/types';
+import { Checksum, Theme, ThemeAsset } from '@shopify/cli-kit/node/themes/types';
interface RemoteThemeResponse {
id: number;
name: string;
@@ -26,5 +25,4 @@ export declare function buildTheme(themeJson?: RemoteThemeResponse): Theme | und
export declare function buildChecksum(asset?: RemoteAssetResponse): Checksum | undefined;
export declare function buildThemeAsset(asset: undefined): undefined;
export declare function buildThemeAsset(asset: RemoteAssetResponse): ThemeAsset;
-export declare function buildBulkUploadResults(bulkUploadResponse: RemoteBulkUploadResponse[], assets: AssetParams[]): Result[];
export {};
\ No newline at end of file
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1966 tests passing in 892 suites. Report generated by 🧪jest coverage report action from f93ed1e |
karreiro
changed the title
karreiro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
refresh the session when 401 errors happenas that logic going to be restored by #5001.