Use app context in app dev #4680
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success1919 tests passing in 875 suites. Report generated by 🧪jest coverage report action from 090246c |
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
|
/snapit |
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
| } else { | ||
| // If no storeFqdn is provided, fetch all stores for the organization and let the user select one. | ||
| const allStores = await developerPlatformClient.devStoresForOrg(organization.id) | ||
| selectedStore = await selectStore(allStores, organization, developerPlatformClient) | ||
| } | ||
|
|
||
| await logMetadata(selectedStore, forceReselectStore) | ||
| selectedStore.shopDomain = await normalizeStoreFqdn(selectedStore.shopDomain) |
There was a problem hiding this comment.
Awesome, this fixes an issue with graphiql not loading when running the new dev (details: https://shopify.slack.com/archives/C073MME9MFA/p1729694637756339)
There was a problem hiding this comment.
Yep! this should fix all usages of the store domain :)
Just waiting for an approval to merge the PR!
WHY are these changes introduced?
Use the generic app-context for all commands
WHAT is this pull request doing?
linkedAppContextandstoreContextinapp devensureDevContext,getAppContextand other utility functionsHow to test your changes?
Test dev!
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist