Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jm/liquid asset hrm add #4661

Closed
wants to merge 7 commits into from

Conversation

jamesmengo
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.51% 8365/11536
🟡 Branches 69.17% 4106/5936
🟡 Functions 71.77% 2186/3046
🟡 Lines 72.81% 7908/10861

Test suite run success

1903 tests passing in 865 suites.

Report generated by 🧪jest coverage report action from bd4d4f8

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/app-management.d.ts
@@ -1,8 +1,6 @@
-import { GraphQLResponse } from './graphql.js';
-import { TypedDocumentNode } from '@graphql-typed-document-node/core';
-import { Variables } from 'graphql-request';
+import { GraphQLVariables, GraphQLResponse } from './graphql.js';
 /**
- * Executes an org-scoped GraphQL query against the App Management API. Uses typed documents.
+ * Executes an org-scoped GraphQL query against the App Management API.
  *
  * @param orgId - The organization ID.
  * @param query - GraphQL query to execute.
@@ -10,7 +8,7 @@ import { Variables } from 'graphql-request';
  * @param variables - GraphQL variables to pass to the query.
  * @returns The response of the query of generic type <T>.
  */
-export declare function appManagementRequestDoc<TResult, TVariables extends Variables>(orgId: string, query: TypedDocumentNode<TResult, TVariables>, token: string, variables?: TVariables): Promise<TResult>;
+export declare function appManagementRequest<T>(orgId: string, query: string, token: string, variables?: GraphQLVariables): Promise<T>;
 /**
  * Sets the next deprecation date from [GraphQL response extensions](https://www.apollographql.com/docs/resources/graphql-glossary/#extensions)
  * if  objects contain a  (ISO 8601-formatted string).
packages/cli-kit/dist/public/node/themes/types.d.ts
@@ -9,13 +9,14 @@ type ThemeFSEvent = {
     type: 'unlink';
     payload: {
         fileKey: Key;
+        onSync?: (fn: () => void) => void;
     };
 } | {
     type: 'add' | 'change';
     payload: {
         fileKey: Key;
         onContent: (fn: (content: string) => void) => void;
-        onSync: (fn: () => void) => void;
+        onSync: (fn: () => Promise<void>) => void;
     };
 };
 export type ThemeFSEventPayload<T extends ThemeFSEventName = 'add'> = (ThemeFSEvent & {

@jamesmengo jamesmengo closed this Oct 17, 2024
@jamesmengo jamesmengo deleted the jm/liquid-asset-hrm-add branch January 6, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant