Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app context in app versions list #4650

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

Use the generic app-context for all commands

WHAT is this pull request doing?

  • Use linkedAppContext in app versions list command
  • Remove ensureVersionsListContext
  • Update tests

How to test your changes?

Just test app versions list, it should continue working as normal

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@isaacroldan isaacroldan requested a review from a team as a code owner October 15, 2024 11:34
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.84% (-0.01% 🔻)
8406/11540
🟡 Branches
69.5% (-0.04% 🔻)
4131/5944
🟡 Functions
71.93% (-0.01% 🔻)
2191/3046
🟡 Lines
73.17% (-0.01% 🔻)
7949/10864
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / context.ts
91.4% (-0.63% 🔻)
85.71% (-1.7% 🔻)
87.1% (-0.4% 🔻)
92.54% (-0.67% 🔻)

Test suite run success

1911 tests passing in 865 suites.

Report generated by 🧪jest coverage report action from 359d76a

@isaacroldan isaacroldan changed the title Use app context in app versions list Use app context in app versions list Oct 15, 2024
@isaacroldan isaacroldan added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 2dd32be Oct 15, 2024
@isaacroldan isaacroldan deleted the use-app-context-in-app-versions-list branch October 15, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants