Skip to content

Commit

Permalink
Merge pull request #5014 from Shopify/jc.download-plugin-ahead-of-tim…
Browse files Browse the repository at this point in the history
…e-with-javy

Download Javy plugin with Javy binary
  • Loading branch information
jeffcharles authored Dec 4, 2024
2 parents c15413e + 78cbc67 commit 7d2f856
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/shy-steaks-lay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': patch
---

Download Javy plugin ahead of time with Javy CLI
3 changes: 2 additions & 1 deletion packages/app/src/cli/services/function/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ export async function installJavy(app: AppInterface) {
const javyRequired = app.allExtensions.some((ext) => ext.features.includes('function') && ext.isJavaScript)
if (javyRequired) {
const javy = javyBinary()
await downloadBinary(javy)
const plugin = javyPluginBinary()
await Promise.all([downloadBinary(javy), downloadBinary(plugin)])
}
}

Expand Down

0 comments on commit 7d2f856

Please sign in to comment.