Merge pull request #5133 from Shopify/use-uuid-to-record-asset-path-i…

…n-manifest Use the auto-generated UID for asset upload path
Shopify · Dec 22, 2024 · 27fceb7 · 27fceb7
2 parents d2be4a3 + f8b6985
commit 27fceb7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/app/src/cli/models/app/app.ts b/packages/app/src/cli/models/app/app.ts
@@ -355,7 +355,7 @@ export class App<
           type: module.externalType,
           handle: module.handle,
           uid: module.uid,
-          assets: module.configuration.uid ?? module.handle,
+          assets: module.uid,
           target: module.contextValue,
           config: (config ?? {}) as JsonMapType,
         }

diff --git a/packages/app/src/cli/services/deploy/bundle.test.ts b/packages/app/src/cli/services/deploy/bundle.test.ts
@@ -40,15 +40,15 @@ describe('bundleAndBuildExtensions', () => {
             type: 'web_pixel_extension_external',
             handle: 'test-ui-extension',
             uid: 'test-ui-extension-uid',
-            assets: 'test-ui-extension',
+            assets: 'test-ui-extension-uid',
             target: '',
             config: {},
           },
           {
             type: 'theme_external',
             handle: 'theme-extension-name',
             uid: themeExtension.uid,
-            assets: 'theme-extension-name',
+            assets: themeExtension.uid,
             target: '',
             config: {
               theme_extension: {