Add tests for requestIdCollection

packages/cli-kit/src/private/node/request-ids.test.ts

@@ -0,0 +1,68 @@
+import {requestIdsCollection} from './request-ids.js'
+import {describe, test, expect, beforeEach} from 'vitest'
+
+describe('RequestIDCollection', () => {
+  beforeEach(() => {
+    requestIdsCollection.clear()
+  })
+
+  test('starts with an empty collection', () => {
+    expect(requestIdsCollection.getRequestIds()).toEqual([])
+  })
+
+  test('adds request IDs to collection', () => {
+    // When
+    requestIdsCollection.addRequestId('request-1')
+    requestIdsCollection.addRequestId('request-2')
+
+    // Then
+    expect(requestIdsCollection.getRequestIds()).toEqual(['request-1', 'request-2'])
+  })
+
+  test('ignores undefined or null request IDs', () => {
+    // When
+    requestIdsCollection.addRequestId(undefined)
+    requestIdsCollection.addRequestId(null)
+    requestIdsCollection.addRequestId('request-1')
+
+    // Then
+    expect(requestIdsCollection.getRequestIds()).toEqual(['request-1'])
+  })
+
+  test('limits collection to MAX_REQUEST_IDS', () => {
+    // When
+    for (let i = 0; i < 120; i++) {
+      requestIdsCollection.addRequestId(`request-${i}`)
+    }
+
+    // Then
+    expect(requestIdsCollection.getRequestIds()).toHaveLength(100)
+    expect(requestIdsCollection.getRequestIds()[0]).toBe('request-0')
+    expect(requestIdsCollection.getRequestIds()[99]).toBe('request-99')
+  })
+
+  test('clear() removes all request IDs', () => {
+    // Given
+    requestIdsCollection.addRequestId('request-1')
+    requestIdsCollection.addRequestId('request-2')
+
+    // When
+    requestIdsCollection.clear()
+
+    // Then
+    expect(requestIdsCollection.getRequestIds()).toEqual([])
+  })
+
+  test('maintains singleton instance', () => {
+    // Given
+    requestIdsCollection.addRequestId('request-1')
+
+    // When
+    const sameInstance = requestIdsCollection
+    sameInstance.addRequestId('request-2')
+
+    // Then
+    expect(requestIdsCollection.getRequestIds()).toEqual(['request-1', 'request-2'])
+    expect(sameInstance.getRequestIds()).toEqual(['request-1', 'request-2'])
+  })
+})

packages/cli-kit/src/private/node/request-ids.ts

@@ -1,7 +1,9 @@
+const MAX_REQUEST_IDS = 100
+
 /**
  * Manages collection of request IDs during command execution
  */
-export class RequestIDCollection {
+class RequestIDCollection {
   private static instance: RequestIDCollection
 
   static getInstance(): RequestIDCollection {
@@ -11,17 +13,14 @@ export class RequestIDCollection {
     return RequestIDCollection.instance
   }
 
-  // We only report the last 1000 request IDs.
-  private readonly maxRequestIds = 1000
   private requestIds: string[] = []
 
-  private constructor() {}
-
   /**
    * Add a request ID to the collection
+   * We only report the first MAX_REQUEST_IDS request IDs.
    */
   addRequestId(requestId: string | undefined | null) {
-    if (requestId) {
+    if (requestId && this.requestIds.length < MAX_REQUEST_IDS) {
       this.requestIds.push(requestId)
     }
   }
@@ -30,7 +29,7 @@ export class RequestIDCollection {
    * Get all collected request IDs as a comma-separated string
    */
   getRequestIds(): string[] {
-    return this.requestIds.slice(-this.maxRequestIds)
+    return this.requestIds
   }
 
   /**