Allow clients to specify urls that should open externally #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiftio
force-pushed
the
dk/allow-specifying-external-urls
branch
from
9841276
to
ef8d041
Compare
kiftio
force-pushed
the
dk/allow-specifying-external-urls
branch
from
ef8d041
to
cc3bd83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
It's difficult to know which URLs should be opened in an external browser with the apis we have available. We get more information in swift, with WKNavigationType and it's
linkActivated.Checkout contains a large number of (frequently changing) URLs making a whitelist difficult to create.
Merchants may have store policies with links to various sites, checkout ui extensions with custom links and so on. The may also be rendered in cross-domain iframes.
This PR would allow merchants to specify any URLs (regex) where loading should be overridden, and we'd instead invoke
onCheckoutLinkClicked(). Which is a little onerous for clients, but with the APIs and information we have available, it might be the best we can do.Example clicking on policy link:
links.mp4
Before you deploy