Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default permission false by default so that commands default to being usable by everyone #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Alan19
Copy link
Contributor

@Alan19 Alan19 commented Oct 7, 2022

No description provided.

@Alan19 Alan19 marked this pull request as draft October 7, 2022 03:47
@Alan19 Alan19 marked this pull request as ready for review October 18, 2022 03:50
@Alan19
Copy link
Contributor Author

Alan19 commented Mar 14, 2023

Not sure if the comment on this file should be updated so that setting it to true would restrict commands to admin only. It's been a while, so I forgot if the previous behavior was inverted so that setting it to true was how you allowed everyone to use a command. If that's the case, I could have it so that the setters are inverted so it's backwards compatible with people who used this function.
https://github.com/ShindouMihou/Velen/pull/28/files#diff-213941229784adc9b23ab55fe847e3af61972bd5b2dc1743bd737569c0d70f04R63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant