Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix + Extra functions #1

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Bug fix + Extra functions #1

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2014

Hello,

I created some additional functions:

  • Remote (WAN) IP
  • Java File writer (basic)

Also created a new scope for IBAN validation and fixed a small issue in the getLineCountForFile (svyIO).

Regards,

Rene van Veen

@p-bakker
Copy link
Member

p-bakker commented Mar 5, 2014

FYI: I'll setup some guidelines for contributing code asap

Paul

@paronne
Copy link
Member

paronne commented Jan 5, 2015

Hi Rene,

I haven't merget the pull request since i cannot handle the change separetely.
However i have cherry-picked your commits on getLineCountForFile and getRemoteIpAddress and merged with our develop branch with small edits (throw an exception if cannot get the remote ip address)

If you would like to pull the IBAN/BAAN functions please create a new svyUtils$ module.
This is required in order to avoid crowding on the svyUtils module itself; specific utility funcions such as these can be easier switched off if part of a separate module.

Paolo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants