-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better timeouts #129
base: main
Are you sure you want to change the base?
Better timeouts #129
Conversation
|
||
|
||
@config_class() | ||
class GPTTestSlowDatasetConfig(GPTSampledDatasetConfig): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't this be moved to a module in the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it has to be run in a separate process (for distributed) which doesn't import the test file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so you're calling the fast-llm CLI in a subprocess in the tests.
✨ Description
Fix: #122, #76
Set a custom timeout for slow operations (data setup, checkpoint save/load/export) using the well-hidden add_ephemeral method. Using a single "long timeout" for simplicity, the alternative would be to have 4-5 separate timeouts, which would be more powerful and actually simpler to implement but also more annoying to configure.
🔍 Type of change
Select all that apply: