Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports/boost: Fix download link, fix paths in patches #25630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kusekushi
Copy link
Contributor

Boostorg's artifactory instance is down, let's switch to github instead.

@Kusekushi Kusekushi requested a review from timschumi as a code owner January 5, 2025 22:50
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 5, 2025
Boostorg's artifactory instance is down, let's switch
to github instead.
@timschumi
Copy link
Member

Do you know by chance why the tarballs differ? It seems like they even have different paths inside, and not just a changed hash due to differences in the way it was archived.

@Kusekushi
Copy link
Contributor Author

They cherry pick files during packaging on releases, see https://github.com/boostorg/release-tools/blob/develop/ci_boost_release.py
Now, at the time of that specific release this script was programmed to upload the cherry picked tarball to both github and their jfrog instance, but it apparently didn't work..? No idea honestly why it didn't work out in this case. I'll continue to try to understand their release process tho if needed so I can give a proper response to that.

@Kusekushi
Copy link
Contributor Author

Might also be that they just didn't put in a github token when running their first script, but at the time ran https://github.com/boostorg/release-tools/blob/develop/github_releases.py instead. Would explain the discrepancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 pr-needs-review PR needs review from a maintainer or community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants