feat: initial implementation of session time counter extension #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batunpc
changed the title
humphd
requested changes
Dec 14, 2022
| @@ -0,0 +1,20 @@ | |||
| /**@type {import('eslint').Linter.Config} */ | |||
| // eslint-disable-next-line no-undef | |||
There was a problem hiding this comment.
Is this needed? Seems odd in the eslint config itself.
There was a problem hiding this comment.
While I was working on this PR, I have used their official vscode repo as a source on how to do this. They have nice documentation and samples.
This particular lines in eslint config were from the base files of their hello world sample in here.
|
|
||
| const interval = setInterval(() => { | ||
| updateSesstionTime(); | ||
| currentSessionTimeItem.text = (sessionTime / 1000).toFixed(0) + " seconds"; |
There was a problem hiding this comment.
Let's use https://www.npmjs.com/package/ms to do this
|
I saw the official vscode repo to put some extensions in extensions folder. I am not sure what could be a good design but maybe having single |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11
I have added the initial implementation to measure active window time for current session for the user. You can investigate
extensions/session-time-counter/src/extension.tsto see my implementation.During the process I had such questions like;
As we build this extension maybe we need to clarify these crucial questions and file corresponding issues to help with the development process.
Let me know what you think 🤩