Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ".import.less" to overrides and variables files #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sircharleswatson
Copy link

This will allow people to use semantic:ui inside a Meteor package and will fix a lot of the problems with getting that to work properly.

This is dependent on the pull request just made here:
Semantic-Org/Semantic-UI-Meteor-Data#1

This will also fix these issues:
#63, #62, and #52

This will possibly fix other issues as well.

With the .import.less extension on the *.overrides and *.variables files, it will work perfectly whether the semantic:ui package is being depended upon in another package, or if it is added directly to an app.

@wursttheke
Copy link

Awesome! Just tried it by checking out your forks (Semantic-UI-Meteor and Semantic-UI-Meteor-Data) and it works perfectly with the official Less package! 👍

@jlukic
Copy link
Member

jlukic commented Sep 25, 2015

You can also edit the less package to add .import and .variables as acceptable file types.

@sircharleswatson
Copy link
Author

@jlukic I think it would take a lot longer for MDG to accept changes to their less package, unfortunately. What do you think would be the best option?

@jlukic
Copy link
Member

jlukic commented Sep 25, 2015

I'm currently monkeypatching mdg less packages. I might talk to someone at meteor about this when i get a chance.

I think this is an alright solution but it will require people to modify their site/ files as well. Which in most cases would have to be manual.

@sircharleswatson
Copy link
Author

@jlukic That makes sense. According to the Less docs, if you pass any file to it that doesn't have .less or .import.less it's supposed to treat it like less. So it'd be good if the MDG Less package had a way to specify certain files to process as Less files.

I needed a quick solution so the easiest way was to change the file extensions here. but if this isn't the best place to do it, I'm fine with that :)

@v3rron
Copy link

v3rron commented Sep 27, 2015

@sircharleswatson wow thanks man, it will help us a lot. App reloading times in development mode now takes forever which is insane :) Really looking forward for new Semantic-UI version with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants