-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] Grid UI could not open session live view #15132
base: trunk
Are you sure you want to change the base?
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
CI Feedback 🧐(Feedback updated until commit 02f1f4a)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #15131
Due to update [email protected] in the commit 334cfaa. The issue is confirmed as screenshot below
Refer to a suggestion https://stackoverflow.com/questions/78125541/how-to-integrate-novnc-in-angular-16-how-to-launch-novnc-terminal-from-angular
With the fix, we can see it works as screenshot below
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix
Description
Fixed an issue preventing session live view in Grid UI.
Updated
RFB
initialization to useRFB.default
.Added event listener for
disconnect
inLiveView
component.Changes walkthrough 📝
LiveView.tsx
Fix and enhance `RFB` initialization in `LiveView`
javascript/grid-ui/src/components/LiveView/LiveView.tsx
RFB
initialization to useRFB.default
.disconnect
event listener to handle disconnection.RFB
instance with updated event handling.