Don't Specify Chart Width #683
Merged
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some charts were appearing narrower than they should. instead of specifying both a height and a width for the charts to fit themselves to, only specify the height. This should fix the old issue of charts erroneously growing to take up all available vertical space in a bad way, and instead should ensure the chart takes up all available horizontal space in a good way. The choice to specify the height on the group div allows for the height to be specified while not maximized, but when the maximized class is applied the max-height value is overwritten. Also fixed some icons who's styles had them hardcoded as white. They disappeared in the white theme.
TOoSmOotH
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some charts were appearing narrower than they should. instead of specifying both a height and a width for the charts to fit themselves to, only specify the height. This should fix the old issue of charts erroneously growing to take up all available vertical space in a bad way, and instead should ensure the chart takes up all available horizontal space in a good way. The choice to specify the height on the group div allows for the height to be specified while not maximized, but when the maximized class is applied the max-height value is overwritten.
Also fixed some icons who's styles had them hardcoded as white. They disappeared in the white theme.