Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmic Text (Continuation of #179) #194

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Cosmic Text (Continuation of #179) #194

wants to merge 27 commits into from

Conversation

LPGhatguy
Copy link
Member

@LPGhatguy LPGhatguy commented Nov 20, 2024

Closes #95.

This PR picks up where #179 left off! I didn't do a great job of reviewing this code when @msparkles was working on it, but now I'm hoping to push this work over the finish line.

I created a new branch and PR because I don't have write access to the original repo from #179.

I changed most of the widget APIs to align them when the main branch to make it easier for folks to migrate, including our game. In tandem, I'm working on upgrading our game to support the changes in this PR and using it as a layout test because it's such a big overhaul!

Remaining Issues

  • Split premultiplied texture format into separate change
  • Split PaintLimits into separate change
  • Investigate sizing issues when using expanded alongside this widget
  • Audit text alignment inside buttons
  • Drag operations that happen outside the textbox bounds always snap to the beginning of the box instead of the nearest position within the box

@LPGhatguy
Copy link
Member Author

Button alignment is currently a little whack. These buttons have a minimum size enforced on them which causes the text to no longer be centered it seems:
image

@LPGhatguy
Copy link
Member Author

fontdue COSMIC text
info panel original info panel progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate using Cosmic Text
2 participants