Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a widget for drawing outlines #191

Closed
wants to merge 4 commits into from
Closed

Conversation

johann2
Copy link

@johann2 johann2 commented Oct 12, 2024

Needed one myself and it seems like it could be useful for others as well.
I guess the same could be achieved with the NineSlice widget, but for simple outlines, this is much more ergonomic and doesn't need any setup.

Also added an example that showcases all the functionality this widget has.

@msparkles
Copy link
Contributor

@johann2 BTW, a tip: when making PRs, cherry-pick the commits you want in the PR into a separate branch, and then make a PR from that

@johann2
Copy link
Author

johann2 commented Oct 18, 2024

@johann2 BTW, a tip: when making PRs, cherry-pick the commits you want in the PR into a separate branch, and then make a PR from that

I'm aware of this, but unfortunately forgot this step. GitHub doesn't allow changing the source branch of PRs, so should I just close this and create another one?

@msparkles
Copy link
Contributor

so should I just close this and create another one?

Yeah, that's the best course of action here really.

@johann2 johann2 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants