Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Relax version constraint for Neos 8 support #3

Merged
merged 1 commit into from
Oct 4, 2023
Merged

FEATURE: Relax version constraint for Neos 8 support #3

merged 1 commit into from
Oct 4, 2023

Conversation

rolandschuetz
Copy link
Contributor

No description provided.

@Sebobo
Copy link
Owner

Sebobo commented Sep 25, 2023

What is the exact reason? I wanted to abandon this package.
Or why would you think it works better technically than the core version in 8.x?

@rolandschuetz
Copy link
Contributor Author

rolandschuetz commented Oct 2, 2023 •
edited
Loading

It's the issue from neos/neos-ui#2930
With the package it works, with the core it doesn't. So I want to use the package to have a working solution. Of course, a fix in the core would be great, but will take longer.

@Sebobo
Copy link
Owner

Sebobo commented Oct 4, 2023

Ok I see and remember now. Because the handling of non absolute resource Uris does not work depending on the environment, I refrained from supporting them in the core feature. I'll merge.

@Sebobo Sebobo merged commit 40ec5b0 into Sebobo:main Oct 4, 2023
@rolandschuetz
Copy link
Contributor Author

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolandschuetz @Sebobo