Merge pull request #26 from Seagate/FMW-73837_Remove_Key_Material

FMW-73837: Remove Key Material Captured in Logs
Seagate · Dec 13, 2024 · 184c125 · 184c125
2 parents 65caa95 + eca3d3f
commit 184c125
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/kmipapi/kmip14.go b/src/kmipapi/kmip14.go
@@ -199,7 +199,6 @@ func (kmips *kmip14service) GetKey(ctx context.Context, connection *tls.Conn, se
 	}
 
 	decoder, item, err := SendRequestMessage(ctx, connection, settings, uint32(kmip14.OperationGet), &payload, false)
-	logger.Debug("get key response item", "item", item)
 
 	if err != nil {
 		logger.Error("get key call to SendRequestMessage failed", "error", err)

diff --git a/src/kmipapi/send.go b/src/kmipapi/send.go
@@ -49,7 +49,7 @@ func SendRequestMessage(ctx context.Context, connection *tls.Conn, settings *Con
 	var err error
 	// var msg kmip.RequestMessage
 
-	if dobatch == true {
+	if dobatch {
 		kmipreq, err = ttlv.Marshal(payload)
 		if err != nil {
 			return nil, nil, fmt.Errorf("dobatch - failed to marshal message, error: %v", err)
@@ -101,7 +101,6 @@ func SendRequestMessage(ctx context.Context, connection *tls.Conn, settings *Con
 
 		logger.Debug("(5) extract response from TTLV buffer")
 		resp := ttlv.TTLV(buf)
-		logger.Debug("ttlv", "response", resp)
 
 		// Create a TTLV decoder from a new reader
 		decoder := ttlv.NewDecoder(bytes.NewReader(resp))
@@ -117,7 +116,6 @@ func SendRequestMessage(ctx context.Context, connection *tls.Conn, settings *Con
 		}
 
 		logger.Debug("(6) extract batch item from response message", "BatchCount", respMsg.ResponseHeader.BatchCount)
-		logger.Debug("response", "message", respMsg)
 		if len(respMsg.BatchItem) == 0 {
 			return nil, nil, fmt.Errorf("response message had not batch items")
 		}