fix(service): only discover devices and add the devices if there are no devices in data store #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd update (#57) * refactor(cli): command usage and example string generation refactor and update * doc(cli): add docker-specific note about service-related cli options
* feat: set the nodes width based on the device id dimensions * feat: add ipaddress to the existed devices in dashboard * feat: add new button to discover new devices and the related interfaces * fix: fix the bug in addDiscoveredHosts interface * fix: fix bug in addDiscoveredBlades interface * feat: add function addDiscoveredDevices with output popup and waiting popup * style: separate lines for discovered blades and hosts * feat: add waiting progress for device discovery * feat: update the content after adding new discovered devices * feat: distinguish node status by border color * feat: prevent the user from manually adding blades to the CMA_Discovered_Blades appliance * style: remove unnecessary stype setup
…e using privileged mode (#60) * feat: update the docker running command to make D-bus available ay priviledged mode * fix: update the docker running command to make D-bus available using privileged mode
scott-howe-1
reviewed
Dec 6, 2024
Co-authored-by: Scott Howe <[email protected]> Signed-off-by: Mengling Ding <[email protected]>
scott-howe-1
reviewed
Dec 6, 2024
scott-howe-1
changed the title
scott-howe-1
approved these changes
Dec 9, 2024
HJ-Fan
reviewed
Dec 9, 2024
HJ-Fan
reviewed
Dec 9, 2024
HJ-Fan
reviewed
Dec 9, 2024
HJ-Fan
reviewed
Dec 9, 2024
HJ-Fan
reviewed
Dec 9, 2024
HJ-Fan
reviewed
Dec 9, 2024
HJ-Fan
reviewed
Dec 9, 2024
HJ-Fan
reviewed
Dec 10, 2024
|
Please remove line 71-78 in cmd/cfm-service/main.go which was added back by the merge. Then you should be good. |
HJ-Fan
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only discover devices and add the devices if there are no devices in data store.
Marked the failed adding devices to unavailable status in PR: #54