Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce release docker image size #19

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Reduce release docker image size #19

merged 5 commits into from
Jul 31, 2024

Conversation

HJ-Fan
Copy link
Collaborator

@HJ-Fan HJ-Fan commented Jul 24, 2024 •
edited
Loading

Using slim version of node image as base, the docker image size is reduced from 1.7G to about 37MB

@HJ-Fan HJ-Fan requested a review from scott-howe-1 July 24, 2024 20:33
@HJ-Fan HJ-Fan self-assigned this Jul 24, 2024
@HJ-Fan HJ-Fan force-pushed the feature/CFM-977_reduce_release_docker_image_size branch from 7123b31 to d13225f Compare July 24, 2024 20:59
Meng-20
Meng-20 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@Meng-20 Meng-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the auto generated code and reducing the docker image size.

@HJ-Fan HJ-Fan merged commit beb92b1 into main Jul 31, 2024
5 checks passed
@HJ-Fan HJ-Fan deleted the feature/CFM-977_reduce_release_docker_image_size branch July 31, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scott-howe-1 scott-howe-1 scott-howe-1 left review comments

@Meng-20 Meng-20 Meng-20 approved these changes

Assignees

@HJ-Fan HJ-Fan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HJ-Fan @scott-howe-1 @Meng-20