Creation dummy node #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
lurenss
requested changes
Mar 3, 2024
scrapegraphai/nodes/text_node.py
Outdated
| KeyError: If the 'url' key is not found in the state, indicating that the | ||
| necessary information to perform the operation is missing. | ||
| """ | ||
| print("---LOADING HTML CODE---") |
There was a problem hiding this comment.
LOADING TEXT CODE, because can read generic text not only html
| text = open("text_example.txt", "r", encoding="utf-8") | ||
|
|
||
| # define the nodes for the graph | ||
| fetch_html_node = TextNode("fetch_html") |
There was a problem hiding this comment.
It isn't supposed to read only html but general text, I would change to fetch_text_node
scrapegraphai/nodes/text_node.py
Outdated
| node_name (str): The unique identifier name for the node. This name is used to | ||
| reference the node within the graph. | ||
| node_type (str, optional): The type of the node, limited to "node" or | ||
| "conditional_node". Defaults to "node". |
There was a problem hiding this comment.
I would rewrite the documentation for this node in order to make as cleas as possible that takes general text, the parameter url for this use case could cause misunderstanding, i would change to file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.