-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qq: Add version 9.7.3.28946 #10555
qq: Add version 9.7.3.28946 #10555
Conversation
qq: Add version 9.7.3.28946
All changes look good. Wait for review from human collaborators.
|
Do QQ and TIM have English UI after installed? Since I'm using Simplified Chinese locale and could not test them. |
I hope this gets merged, but I'm also not going to lie, the answer is No and No. |
So, these manifests should go to other buckets IMO, e.g. @chawyehsu's https://github.com/chawyehsu/dorado, and there're many other Chinese only ones. |
My review for it: objection. |
I am actually aware of @chawyehsu's https://github.com/chawyehsu/dorado, but I still want to submit that inventory file to the Extras repository for several reasons.
|
Thank you for your comments. I guess I didn't post a screenshot though, or you didn't actually go and test it to conclude that it wouldn't work without QQ Protect. |
Claiming third-party buckets are risky is somewhat negative to the community. Most of them are created by community members because of their own pure needs. But don't get me wrong, ppl should always double-check the packages they use.
My bucket was not for such a situation from the beginning. I created it for myself and built up its reputation on my own. No one else has a duty to submit any manifest that does not satisfy Scoop org-owed buckets' criteria to my bucket. So please do not give such recommendations. We, at least I and @ rasa, expect there should be more buckets that are built and maintained by the community members themselves, and stuff related to buckets works in a more decentralized way. Remember you can create your own bucket. (Ross tell me if I'm wrong) In fact, I don't quite care about the language-specific maintenance criteria after |
Okay, I'll not recommend your bucket since it's personal as you said. I've checked git log of But there're over 1800 apps in |
I'm concerned about this, too. And users will suffer from bloated buckets. Still, you have to admit that ppl thinking of having a manifest included in org-owned buckets that would leverage the reputation will keep submitting new apps whatever criteria are there, they can actually create their own buckets as I comment above tho. We have to find a solution to solve this rather than add limitations. ScoopInstaller/Scoop#5119 was great enough at least for now though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify script and change checkver url
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Thank you. Local test passed. |
Scripts contributed by ScoopInstaller#10555
Closes #10558