Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qq: Add version 9.7.3.28946 #10555

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Conversation

StarsbySea
Copy link
Contributor

@StarsbySea StarsbySea commented Feb 19, 2023

Closes #10558

qq: Add version 9.7.3.28946
@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

qq

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@niheaven niheaven added the package-request-needed Need package-request issue label Feb 19, 2023
@niheaven
Copy link
Member

Do QQ and TIM have English UI after installed? Since I'm using Simplified Chinese locale and could not test them.

@StarsbySea
Copy link
Contributor Author

I hope this gets merged, but I'm also not going to lie, the answer is No and No.
However after testing the system is in English, the software can display Simplified Chinese and work fine. Of course as a chat software, even if the interface is all in Simplified Chinese it still works (just chatting)

@niheaven
Copy link
Member

So, these manifests should go to other buckets IMO, e.g. @chawyehsu's https://github.com/chawyehsu/dorado, and there're many other Chinese only ones.

@chawyehsu
Copy link
Member

My review for it: objection.
Not only because of the language criteria. I do not think this will work by simply extracting files from the installers, neither QQ nor TIM. You have to investigate and ensure it really works in a new environment that did not have QQ/TIM, more specifically QQProtect, installed before. Otherwise: chawyehsu/dorado#11, chawyehsu/dorado#370.

@StarsbySea
Copy link
Contributor Author

So, these manifests should go to other buckets IMO, e.g. @chawyehsu's https://github.com/chawyehsu/dorado, and there're many other Chinese only ones.

I am actually aware of @chawyehsu's https://github.com/chawyehsu/dorado, but I still want to submit that inventory file to the Extras repository for several reasons.

  1. Extras has a reputation as one of the few official repositories, maintained by a wide range of professional community members, and it would be convenient for many users who just want to install software to be added to it. (rather than finding an uncertain third party repository to run potentially risky scripts or software)
  2. Searching through the Scoop.sh website, you can find at least 20+ repositories that provide QQ manifests, suggesting that many Scoop users actually use the software's configuration, perhaps because the official Extras don't have it and have to (painfully) create it themselves
  3. In the face of objections from baidupcs-go: Add version 3.8.4 Main#2938 (comment), I would like to say that if a software has a large enough user base and if the users need it, it is possible to consider Allowing software to be added to a repository. Maintenance is not really a problem, because if the software is used by enough people and is open source, there will be users who will raise issues, or pull requests to fix them.
    Of course, in the specific case of QQ and TIM, the software has a simplified Chinese interface, and there are at least two maintainers I know of who can read Chinese, so I don't think it should be too difficult to maintain. (All of this is debatable, of course).

@StarsbySea
Copy link
Contributor Author

My review for it: objection. Not only because of the language criteria. I do not think this will work by simply extracting files from the installers, neither QQ nor TIM. You have to investigate and ensure it really works in a new environment that did not have QQ/TIM, more specifically QQProtect, installed before. Otherwise: chawyehsu/dorado#11, chawyehsu/dorado#370.

Thank you for your comments.

I guess I didn't post a screenshot though, or you didn't actually go and test it to conclude that it wouldn't work without QQ Protect.
To be honest, I've tested both manifest files in Windows Sandbox (must admit the sandbox must be clean Windows. test was done by copying the finished QQ/TIM folder into the sandbox, running it manually and trying to log in) and both worked fine with no error messages.
I've posted screenshots of the test below for you to see, but a better way is to try it out for yourself. (Just a personal opinion, it would be a waste of time and emotion and not good for community dialogue and development if you just thought about it and didn't even bother to try it out before coming to a conclusion)

QQ
TIM

@chawyehsu
Copy link
Member

chawyehsu commented Feb 20, 2023

Claiming third-party buckets are risky is somewhat negative to the community. Most of them are created by community members because of their own pure needs. But don't get me wrong, ppl should always double-check the packages they use.

.. @ chawyehsu's https://github.com/chawyehsu/dorado, and there're many ..

My bucket was not for such a situation from the beginning. I created it for myself and built up its reputation on my own. No one else has a duty to submit any manifest that does not satisfy Scoop org-owed buckets' criteria to my bucket. So please do not give such recommendations. We, at least I and @ rasa, expect there should be more buckets that are built and maintained by the community members themselves, and stuff related to buckets works in a more decentralized way. Remember you can create your own bucket. (Ross tell me if I'm wrong)

In fact, I don't quite care about the language-specific maintenance criteria after winget started to include almost all incoming packages without basically any clear requirements. I don't remember who introduced and enforced such criteria for our buckets. I do care about package usability, especially for restricted users whom Scoop was made for, naming convention, and maintainability, however. That's another story. Not going to discuss it here. On the other hand, I'll be excited if anyone makes these two apps work with Scoop without requiring admin rights. I'll be happy to adapt then. Anyways I'll apologize for my preconceived comment and have it a try under VMs using a restricted user account. I'll review the manifest and approve this when it works under my VM, but if there is any objection from other collaborators, it's up to them.

@niheaven
Copy link
Member

Okay, I'll not recommend your bucket since it's personal as you said.

I've checked git log of package_request issue template and the language criteria is introduced by me but I'm sure it's not from me, and also forget who said this first. If there's a need to accept all types of apps, we could remove any of these criteria and make official buckets more general ones.

But there're over 1800 apps in extras with over 100 package-adding PRs and the sub-directory structure (in any categories) is still not adopted 'cos incompatibility of search-engine, I'm really worried about the maintainability of this bucket.

bucket/qq.json Outdated Show resolved Hide resolved
bucket/qq.json Outdated Show resolved Hide resolved
@chawyehsu
Copy link
Member

chawyehsu commented Feb 21, 2023

But there're over 1800 apps in extras with over 100 package-adding PRs and the sub-directory structure (in any categories) is still not adopted 'cos incompatibility of search-engine, I'm really worried about the maintainability of this bucket.

I'm concerned about this, too. And users will suffer from bloated buckets. Still, you have to admit that ppl thinking of having a manifest included in org-owned buckets that would leverage the reputation will keep submitting new apps whatever criteria are there, they can actually create their own buckets as I comment above tho. We have to find a solution to solve this rather than add limitations. ScoopInstaller/Scoop#5119 was great enough at least for now though.

@StarsbySea StarsbySea requested review from chawyehsu and rashil2000 and removed request for chawyehsu and rashil2000 February 21, 2023 15:29
Copy link
Member

@niheaven niheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify script and change checkver url

bucket/qq.json Outdated Show resolved Hide resolved
bucket/qq.json Outdated Show resolved Hide resolved
StarsbySea and others added 2 commits February 22, 2023 10:09
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
@StarsbySea
Copy link
Contributor Author

Simplify script and change checkver url

Thank you. Local test passed.

@niheaven niheaven merged commit 2355004 into ScoopInstaller:master Feb 22, 2023
@StarsbySea StarsbySea deleted the patch-1 branch February 22, 2023 10:41
StarsbySea added a commit to StarsbySea/Extras that referenced this pull request Feb 22, 2023
@b4imetu b4imetu mentioned this pull request Jul 7, 2023
1 task
@b4imetu b4imetu mentioned this pull request Jan 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package-request-needed Need package-request issue review-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: QQ
4 participants