Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream requestbody to file and convert from file #12

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Stream requestbody to file and convert from file #12

wants to merge 1 commit into from

Conversation

Hikariii
Copy link
Member

  • Write POST-body to html file and use that as base for pdf conversion
  • refactor some code

fixes [sc-35362]

annervisser
annervisser suggested changes Apr 22, 2024
View reviewed changes
src/package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓

This and bun.lockb are both unnecessary, probably an accidental bun install in the wrong directory

src/bun.lockb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

luukvhoudt
luukvhoudt reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@luukvhoudt luukvhoudt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still pass the test? I think these changes require the test to be adjusted as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luukvhoudt luukvhoudt luukvhoudt left review comments

@annervisser annervisser annervisser requested changes

Assignees

@Hikariii Hikariii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hikariii @annervisser @luukvhoudt