Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new re-entrant do-nothing script #6062

Merged
merged 32 commits into from
Nov 4, 2024

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Jul 18, 2024

🚀 Pull Request

Description

Just a draft so we can trial it in the upcoming release.

https://github.com/SciTools-incubator/nothing

  • need to set appropriate permissions for the new repo

Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (7bca716) to head (33f2cd7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6062   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          88       88           
  Lines       23315    23315           
  Branches     4338     4338           
=======================================
  Hits        20945    20945           
  Misses       1644     1644           
  Partials      726      726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers trexfeathers self-assigned this Jul 19, 2024
tools/release_do_nothing.py Outdated Show resolved Hide resolved
tools/release_do_nothing.py Outdated Show resolved Hide resolved
tools/release_do_nothing.py Outdated Show resolved Hide resolved
tools/release_do_nothing.py Show resolved Hide resolved
tools/release_do_nothing.py Outdated Show resolved Hide resolved
tools/release_do_nothing.py Outdated Show resolved Hide resolved
tools/release_do_nothing.py Outdated Show resolved Hide resolved
tools/release_do_nothing.py Show resolved Hide resolved
tools/release_do_nothing.py Outdated Show resolved Hide resolved
tools/release_do_nothing.py Show resolved Hide resolved
@trexfeathers trexfeathers marked this pull request as ready for review August 14, 2024 14:53
@pp-mo
Copy link
Member

pp-mo commented Sep 12, 2024

Tested this in use + it was handy
But it would be nice if the "nothing" package allowed you to restart from latest stored.
I created a couple of issues to suggest improvements in the common code package : SciTools-incubator/nothing#1 SciTools-incubator/nothing#2

@trexfeathers
Copy link
Contributor Author

Tested this in use + it was handy But it would be nice if the "nothing" package allowed you to restart from latest stored. I created a couple of issues to suggest improvements in the common code package : SciTools-incubator/nothing#1 SciTools-incubator/nothing#2

Thanks @pp-mo these are great suggestions! I don't consider them a blocker to this PR, which I know @HGWright is looking at today.

@ESadek-MO ESadek-MO self-assigned this Oct 23, 2024
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're pretty much there. There are a few comments sitting on this PR, and I've added one of my own. I think once they're all done we merge this is, and if there's further issues we fix those when they arise.

tools/release_do_nothing.py Outdated Show resolved Hide resolved
@ESadek-MO ESadek-MO merged commit 5714ed6 into SciTools:main Nov 4, 2024
21 checks passed
@trexfeathers
Copy link
Contributor Author

Thanks @ESadek-MO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants