-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new re-entrant do-nothing script #6062
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6062 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 88 88
Lines 23315 23315
Branches 4338 4338
=======================================
Hits 20945 20945
Misses 1644 1644
Partials 726 726 ☔ View full report in Codecov by Sentry. |
Tested this in use + it was handy |
Thanks @pp-mo these are great suggestions! I don't consider them a blocker to this PR, which I know @HGWright is looking at today. |
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're pretty much there. There are a few comments sitting on this PR, and I've added one of my own. I think once they're all done we merge this is, and if there's further issues we fix those when they arise.
Thanks @ESadek-MO! |
🚀 Pull Request
Description
Just a draft so we can trial it in the upcoming release.
https://github.com/SciTools-incubator/nothing
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: