Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for enums #293

Merged
merged 53 commits into from
Nov 30, 2023
Merged

updated for enums #293

merged 53 commits into from
Nov 30, 2023

Conversation

ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Jul 30, 2023

Closes #263

Introducing enums into iris esmf_regrid, to make code changes easier, user input more directed and prevent unexpected inputs.

@ESadek-MO ESadek-MO marked this pull request as draft August 8, 2023 10:05
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be33a81) 98.81% compared to head (91be20c) 98.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   98.81%   98.86%   +0.04%     
==========================================
  Files          34       36       +2     
  Lines        3806     3862      +56     
==========================================
+ Hits         3761     3818      +57     
+ Misses         45       44       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ESadek-MO ESadek-MO marked this pull request as ready for review August 22, 2023 08:42
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I think this adds some good structure internally and makes the connection to ESMPy clearer. I think it could be possible to do this in a more lenient way with just a few tweaks.

esmf_regrid/constants.py Outdated Show resolved Hide resolved
esmf_regrid/tests/unit/schemes/test__ESMFRegridder.py Outdated Show resolved Hide resolved
esmf_regrid/constants.py Show resolved Hide resolved
esmf_regrid/esmf_regridder.py Outdated Show resolved Hide resolved
esmf_regrid/esmf_regridder.py Outdated Show resolved Hide resolved
esmf_regrid/schemes.py Outdated Show resolved Hide resolved
esmf_regrid/schemes.py Outdated Show resolved Hide resolved
esmf_regrid/schemes.py Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a couple minor things and this is looking good to go.

esmf_regrid/schemes.py Outdated Show resolved Hide resolved
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Thanks for soldiering on with this one @ESadek-MO.

@stephenworsley stephenworsley merged commit e83b7be into SciTools:main Nov 30, 2023
15 checks passed
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request Apr 25, 2024
* main: (42 commits)
  Update lockfiles and fix for new esmpy (SciTools#342)
  Fix for esmpy (SciTools#353)
  Fix usage of map_blocks (SciTools#338)
  Revert "Updated environment lockfiles (SciTools#335)" (SciTools#341)
  Updated environment lockfiles (SciTools#335)
  Bump actions/cache from 3 to 4 (SciTools#333)
  Bump actions/upload-artifact from 3 to 4 (SciTools#324)
  Bump actions/stale from 8.0.0 to 9.0.0 (SciTools#322)
  fix asv (SciTools#339)
  [pre-commit.ci] pre-commit autoupdate (SciTools#330)
  Bump scitools/workflows from 2023.09.0 to 2024.01.0 (SciTools#334)
  Updated environment lockfiles (SciTools#327)
  [pre-commit.ci] pre-commit autoupdate (SciTools#328)
  Updated environment lockfiles (SciTools#304)
  Add CITATION.cff (SciTools#319)
  updated for enums (SciTools#293)
  Flake8 compliant type checking. (SciTools#316)
  update to v0.10.dev0 (SciTools#314)
  Update to v0.9 (SciTools#313)
  First pass at mesh to mesh (SciTools#311)
  ...

# Conflicts:
#	CHANGELOG.md
#	esmf_regrid/esmf_regridder.py
#	esmf_regrid/schemes.py
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request May 2, 2024
* main: (29 commits)
  Bump scitools/workflows from 2024.01.0 to 2024.04.3 (SciTools#356)
  Bump peter-evans/create-pull-request from 5.0.2 to 6.0.5 (SciTools#355)
  [pre-commit.ci] pre-commit autoupdate (SciTools#336)
  Updated environment lockfiles (SciTools#344)
  Update lockfiles and fix for new esmpy (SciTools#342)
  Fix for esmpy (SciTools#353)
  Fix usage of map_blocks (SciTools#338)
  Revert "Updated environment lockfiles (SciTools#335)" (SciTools#341)
  Updated environment lockfiles (SciTools#335)
  Bump actions/cache from 3 to 4 (SciTools#333)
  Bump actions/upload-artifact from 3 to 4 (SciTools#324)
  Bump actions/stale from 8.0.0 to 9.0.0 (SciTools#322)
  fix asv (SciTools#339)
  [pre-commit.ci] pre-commit autoupdate (SciTools#330)
  Bump scitools/workflows from 2023.09.0 to 2024.01.0 (SciTools#334)
  Updated environment lockfiles (SciTools#327)
  [pre-commit.ci] pre-commit autoupdate (SciTools#328)
  Updated environment lockfiles (SciTools#304)
  Add CITATION.cff (SciTools#319)
  updated for enums (SciTools#293)
  ...

# Conflicts:
#	esmf_regrid/schemes.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use enum around the codebase
3 participants