Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to initialise from mesh #289

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Add option to initialise from mesh #289

merged 5 commits into from
Aug 22, 2023

Conversation

stephenworsley
Copy link
Contributor

Adresses #245

@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #289 (e860743) into main (0528a2a) will decrease coverage by 0.06%.
Report is 10 commits behind head on main.
The diff coverage is 95.68%.

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   98.79%   98.73%   -0.06%     
==========================================
  Files          33       33              
  Lines        3563     3642      +79     
==========================================
+ Hits         3520     3596      +76     
- Misses         43       46       +3
Files Changed Coverage Δ
...smf_regrid/tests/unit/schemes/test_ESMFBilinear.py 100.00% <ø> (ø)
esmf_regrid/schemes.py 95.57% <90.74%> (-0.48%) ⬇️
esmf_regrid/experimental/unstructured_scheme.py 94.11% <100.00%> (+0.17%) ⬆️
...nstructured_scheme/test_GridToMeshESMFRegridder.py 100.00% <100.00%> (ø)
esmf_regrid/tests/unit/schemes/__init__.py 100.00% <100.00%> (ø)
...regrid/tests/unit/schemes/test_ESMFAreaWeighted.py 100.00% <100.00%> (ø)
...sts/unit/schemes/test_ESMFAreaWeightedRegridder.py 100.00% <100.00%> (ø)
esmf_regrid/tests/unit/schemes/test_ESMFNearest.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephenworsley stephenworsley marked this pull request as ready for review August 17, 2023 09:24
HGWright
HGWright approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, tests all passing, thanks for the changes we talked about!

@HGWright HGWright merged commit 29b63fb into SciTools:main Aug 22, 2023
@stephenworsley stephenworsley mentioned this pull request Aug 23, 2023
Closed
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request Aug 31, 2023
@stephenworsley
Merge branch 'main' into pre-commit-ci-update-config_fix
95b70a7 
* main:
  Bump scitools/workflows from 2023.05.0 to 2023.06.0 (SciTools#282)
  Updated environment lockfiles (SciTools#296)
  Fix start index bug (SciTools#301)
  extending stale GHA time (SciTools#302)
  ASV v0.6 - no longer use strict parameter. (SciTools#297)
  update to v0.9.dev0 (SciTools#299)
  update to v0.8.0 (SciTools#298)
  Add option to initialise from mesh (SciTools#289)
  Updated environment lockfiles (SciTools#295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HGWright HGWright HGWright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenworsley @HGWright