Merge pull request #103 from SebastianM-C/smc/fix

Fix possible `StackOverflowError`s for `remake_buffer` & `InitializationProblem`s
SciML · Oct 16, 2024 · 7b37511 · 7b37511
2 parents 1e08e11 + 8f9fa49
commit 7b37511
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/remake.jl b/src/remake.jl
@@ -55,6 +55,8 @@ function remake_buffer(sys, oldbuffer::AbstractArray, idxs, vals)
     return newbuffer
 end
 
+remake_buffer(sys, ::Nothing, idxs, vals) = nothing
+
 function remake_buffer(sys, oldbuffer, idxs, vals)
     remake_buffer(sys, oldbuffer, Dict(idxs .=> vals))
 end

diff --git a/test/remake_test.jl b/test/remake_test.jl
@@ -71,3 +71,5 @@ for (buf, newbuf, idxs, vals) in [
     @test newbuf == _newbuf # test values
     @test typeof(newbuf) == typeof(_newbuf) # ensure appropriate type
 end
+
+@test isnothing(remake_buffer(sys, nothing, [], []))