-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SCCNonlinearSolve #502
Conversation
Note the This will start as undocumented and experimental so we can work out the kinks. It has a few allocations, I'm not worrying about those yet, correctness first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really cool! Mostly just general readability/interface comments. I'm looking forward to targeting this with MTK, not so much figuring out how SII will have to interact with it 😅
Co-authored-by: Aayush Sabharwal <[email protected]>
Co-authored-by: Aayush Sabharwal <[email protected]>
Co-authored-by: Aayush Sabharwal <[email protected]>
Co-authored-by: Aayush Sabharwal <[email protected]>
@AayushSabharwal I see where the confusion was from yesterday: I didn't have the fully final version pushed to the package. This is now set to the parameter mutation form I mentioned. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Requires SciML/SciMLBase.jl#861
Right now this just handles
solve
. I want to get a first version in, then the todos for next steps are:init
step!