Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move RobustMultiNewton to NonlinearSolveFirstOrder #499

Merged
merged 2 commits into from
Nov 18, 2024
Merged

refactor: Move RobustMultiNewton to NonlinearSolveFirstOrder #499

merged 2 commits into from
Nov 18, 2024

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Nov 12, 2024

Continue #494

@ChrisRackauckas
Copy link
Member

Test failure looks unrelated.

@avik-pal
Copy link
Member

No it is related, it needs an implicit import

@avik-pal
Copy link
Member

The MTK tests are unrelated. @AayushSabharwal the MTK tests seem incorrect, no-init cache doesn't have u

@AayushSabharwal
Copy link
Member

NonlinearSolve caches don't follow their own interface 😅 I'll PR to fix this

@AayushSabharwal
Copy link
Member

#506

@ChrisRackauckas ChrisRackauckas merged commit ae57fb6 into SciML:master Nov 18, 2024
18 of 37 checks passed
@ErikQQY ErikQQY deleted the qqy/move_robust branch November 18, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avik-pal avik-pal avik-pal left review comments

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ErikQQY @ChrisRackauckas @avik-pal @AayushSabharwal