Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the function bicoloring #93

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add the function bicoloring #93

wants to merge 2 commits into from

Conversation

amontoison
Copy link

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

#69

@gdalle gdalle self-requested a review November 10, 2024 18:23
@gdalle gdalle self-assigned this Nov 10, 2024
amontoison
amontoison commented Nov 10, 2024
View reviewed changes
src/sparse.jl Outdated Show resolved Hide resolved
@gdalle
Copy link
Collaborator

gdalle commented Nov 12, 2024

In principle this would be good but I suggest we put it on hold until we fully figure out bicoloring and neutral colors in SparseMatrixColorings.jl. Converting this PR to draft in the meantime so that it doesn't get merged accidentally.

@gdalle gdalle marked this pull request as draft November 12, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdalle gdalle Awaiting requested review from gdalle

Assignees

@gdalle gdalle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amontoison @gdalle