Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proposal metadata and e2e tests #1662

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Nov 15, 2024

Description

Add a new feature to display and edit proposal metadata with a tabbed interface. Improve state management with a new effect for handling property updates. Add a Cypress test to verify the proposal metadata functionality

Motivation

Metadata was added in the backend but not shown or used in the frontend

Fixes:

Please provide a list of the fixes implemented in this PR

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Add a new feature to display and edit proposal metadata with a tabbed interface, and enhance the proposal detail component to include a proposal type field. Improve state management with a new effect for handling property updates. Add a Cypress test to verify the proposal type functionality.

New Features:

  • Introduce a new feature to display and edit proposal metadata with a tabbed interface, allowing users to view and edit metadata based on their access rights.

Enhancements:

  • Enhance the proposal detail component to include a proposal type field and improve metadata handling with a new tabbed interface for viewing and editing.
  • Add a new effect in the state management to handle property updates for proposals, improving the data flow and state management.

Tests:

  • Add a new Cypress test to verify the proposal type is displayed and updated correctly, ensuring the new feature works as expected.

Summary by Sourcery

Add a new feature to display and edit proposal metadata with a tabbed interface, enhance the proposal detail component, and improve state management with a new effect for handling property updates. Include a Cypress test to verify the proposal metadata functionality.

New Features:

  • Introduce a new feature to display and edit proposal metadata with a tabbed interface, allowing users to view and edit metadata based on their access rights.

Enhancements:

  • Enhance the proposal detail component to include a proposal type field and improve metadata handling with a new tabbed interface for viewing and editing.
  • Add a new effect in the state management to handle property updates for proposals, improving the data flow and state management.

Tests:

  • Add a new Cypress test to verify the proposal type is displayed and updated correctly, ensuring the new feature works as expected.

@martin-trajanovski martin-trajanovski changed the title Swap 4300 proposal metadata feat: proposal metadata and e2e tests Nov 19, 2024
@martin-trajanovski martin-trajanovski marked this pull request as ready for review November 19, 2024 10:07
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martin-trajanovski - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Action types in proposals.actions.ts use '[Dataset]' instead of '[Proposal]' for updateProperty actions - this should be updated for consistency
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martin-trajanovski martin-trajanovski merged commit b5b364e into master Nov 20, 2024
6 checks passed
@martin-trajanovski martin-trajanovski deleted the SWAP-4300-proposal-metadata branch November 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants