Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/bounding client rect #218

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Issue/bounding client rect #218

merged 4 commits into from
Oct 3, 2024

Conversation

danielwiehl
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Fix
  • Feature
  • Documentation
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Performance (changes that improve performance)
  • Test (adding missing tests, refactoring tests; no production code change)
  • Chore (other changes like formatting, updating the license, removal of deprecations, etc)
  • Deps (changes related to updating dependencies)
  • CI (changes to our CI configuration files and scripts)
  • Revert (revert of a previous commit)
  • Release (publish a new release)
  • Other... Please describe:

Issue

Issue Number: #

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danielwiehl
fix(ɵcomponents/keyvalue): support null properties
0b45d57
@danielwiehl
fix(components/sashbox): prevent overflow when moving splitter
83c4b3c 
Moving the splitter between sashes sometimes caused the sashbox or sashes to overflow.
@danielwiehl danielwiehl force-pushed the issue/bounding-client-rect branch 4 times, most recently from 9eea1a3 to ca98230 Compare October 1, 2024 08:43
@danielwiehl
perf(toolkit/observable): optimize position detection in `fromBoundin…
ea5923b 
…gClientRect$`

There is no native browser API for observing an element's position. The new implementation uses the Intersection Observer API to detect position changes, significantly improving performance compared to the previous approach, which required monitoring numerous DOM elements for resizing, scrolling, and DOM changes.
@danielwiehl danielwiehl force-pushed the issue/bounding-client-rect branch 3 times, most recently from 30170ed to a0a9c20 Compare October 2, 2024 16:34
@danielwiehl
fix(components/sashbox): ensure sash resizes to minimum size
9cada61 
Quickly moving the divider now correctly resizes the sash to its minimum size.
@danielwiehl danielwiehl force-pushed the issue/bounding-client-rect branch from a0a9c20 to 9cada61 Compare October 3, 2024 07:21
@Marcarrian Marcarrian merged commit e39a347 into master Oct 3, 2024
30 checks passed
@Marcarrian Marcarrian deleted the issue/bounding-client-rect branch October 3, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcarrian Marcarrian Marcarrian approved these changes

@k-genov k-genov Awaiting requested review from k-genov

Assignees

@Marcarrian Marcarrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielwiehl @Marcarrian