Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin mlkit versions to prevent crash in scanning on android #7

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

smallTrogdor
Copy link
Collaborator

@smallTrogdor smallTrogdor commented Dec 18, 2024

Proposed changes

Currently, the scanning of mlkit is broken on some Android devices (specifically SBB devices) with the latest versions of the mlkit.

This pins the last working versions.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@smallTrogdor smallTrogdor requested a review from a team as a code owner December 18, 2024 18:51
@smallTrogdor smallTrogdor changed the title fix: pin mlkit versions to fix crash in scanning fix: pin mlkit versions to prevent crash in scanning on android Dec 18, 2024
@smallTrogdor smallTrogdor merged commit 8cd946d into main Dec 18, 2024
9 checks passed
@smallTrogdor smallTrogdor deleted the bugfix/fix-mlkit-crash-by-pinning-lower-version branch December 18, 2024 19:00
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant