fix: Fixed loading named settings (#50)

Refs: #51
SchweizerischeBundesbahnen · Jun 28, 2024 · 23a96ed · 23a96ed
1 parent f3f46ea
commit 23a96ed
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/app/src/main/resources/js/custom-select.js b/app/src/main/resources/js/custom-select.js
@@ -126,6 +126,16 @@ SbbCustomSelect.prototype.selectMultipleValues = function(values) {
     this.handleChange();
 };
 
+// Using code like:
+// this.selectElement.innerHTML = "<option>" + document.createTextNode(selectedCheckbox.parentElement.textContent).textContent + "</option>"
+// results in XSS vulnerability. The code below solves this issue.
+SbbCustomSelect.prototype.setSelectedOptionValue = function(optionText) {
+    const optionElement = document.createElement("option");
+    optionElement.textContent = optionText;
+    this.selectElement.innerHTML = '';
+    this.selectElement.appendChild(optionElement);
+};
+
 SbbCustomSelect.prototype.handleChange = function(event) {
     if (this.mutiselect) {
         this.setSelectedOptionValue(this.getSelectedText().join(", "));
@@ -161,14 +171,4 @@ SbbCustomSelect.prototype.handleChange = function(event) {
         }
         this.checkboxContainer.style.display = "none";
     }
-
-    // Using code like:
-    // this.selectElement.innerHTML = "<option>" + document.createTextNode(selectedCheckbox.parentElement.textContent).textContent + "</option>"
-    // results in XSS vulnerability. The code below solves this issue.
-    SbbCustomSelect.prototype.setSelectedOptionValue = function(optionText) {
-        const optionElement = document.createElement("option");
-        optionElement.textContent = optionText;
-        this.selectElement.innerHTML = '';
-        this.selectElement.appendChild(optionElement);
-    };
 }