Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust focus and border colors to new Figma variables #2235

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

fix: adjust focus and border colors to new Figma variables #2235

wants to merge 17 commits into from

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Dec 4, 2024 •
edited
Loading

Relates to #2054, #2124, #2054 (comment)

  • update all components to use the new Figma border and focus variables
  • also fix several incorrect colors for the OnyxButton

Checklist

  • The added / edited code has been documented with JSDoc
  • All changes are documented in the documentation app (folder apps/docs)
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3c5e496

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

larsrickert and others added 12 commits December 4, 2024 14:09
@larsrickert
delete all screenshots
837c247
@github-actions @larsrickert
chore: update Playwright screenshots (#2236)
367f58e 
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: larsrickert <[email protected]>
@github-actions @larsrickert
chore: update Playwright screenshots (#2237)
00e0836 
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: larsrickert <[email protected]>
@larsrickert
fix button styles
5b1d474
@larsrickert
delete all screenshots
f9b4fed
@github-actions @larsrickert
chore: update Playwright screenshots (#2240)
536cc5b 
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: larsrickert <[email protected]>
@larsrickert
fix button text styles
4ef2450
@larsrickert
delete images
7ae59d0
@larsrickert
fix icon button danger font color
8c6edc1
@github-actions @larsrickert
chore: update Playwright screenshots (#2241)
0c16685 
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: larsrickert <[email protected]>
@github-actions @larsrickert
feat: update Figma variables (#2242)
ca43170 
This is an auto-generated pull request.
All variables have been updated from the [Figma
file](https://www.figma.com/design/YfEUBOHk4J4nYrk04geswG).

Co-authored-by: larsrickert <[email protected]>
@github-actions @larsrickert
feat: update Figma variables (#2243)
3c5e496 
This is an auto-generated pull request.
All variables have been updated from the [Figma
file](https://www.figma.com/design/YfEUBOHk4J4nYrk04geswG).

Co-authored-by: larsrickert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@larsrickert