Lint CSS build with .browserslistrc

[oemueller]

Relates to #1970

First do pnpm i, then run pnpm stylelint to lint the Onyx CSS bundle based on the supported browsers in .browserslistrc
This does NOT lint the styles in single Vue components, since the plugin only supports CSS, no SCSS.
Currently only warnings are produced.

A sample output looks like this:

Unexpected browser feature "css-resize" is not supported by Safari on iOS
15.6-15.8,16.6-16.7,17.5,17.6-17.7,18.0,18.1

How does this help ?

We get almost 200 warnings, mainly because of Firefox ESR.

Ideas:

We could run stylelint in the pipeline, parse the output and only fail on problems in certain situations. For example when only the latest Firefox or Safari version is affected.

Or we can just keep the command in package.json and just run it manually to validate.

Checklist

• The added / edited code has been documented with JSDoc
• All changes are documented in the documentation app (folder apps/docs)
• A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 61b3d44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[JoCa96]

Please extend the turbo.json with stylelint depending on build

[larsrickert]

@JoCa96 I am not sure if should mix up build and lint. What do you think about adding a separate styling step to the PR check pipeline?

[JoCa96]

I meant that running stylelint depends on build, so this should be considered by turbo.
In the pipeline we can do it as part of the linting :)

[oemueller]

I added stylelint to check.yml

• should we still want to add it to turbo ?
• stylelint creates only warnings currently on standard output. That's also written to a text file. Do you have an idea what to do with the file ? 😃 Not sure about the possibilities here ..

[JoCa96]

I would assume the command gives an appropriate exit code that we can use in the CI and local checks?