feat(engine): Refactor engine to support modular templates #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
|
Nice one, I also drafted a new interface two days ago which is not fully implemented yet but I guess we have some nice approaches to discuss now 🕺🏻 |
Signed-off-by: Steffen Exler <[email protected]>
Awesome 🤩 |
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Open
MarvinJWendt
changed the title
|
Maybe it's a good idea to split the view interface into a separate PR to make this easier to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to the template engine to allow modular templates. A new module interface has been added, making it possible to create template modules in a separate git repository or folder, or even a custom binary. This allows users to create custom combinations of modules or add their own to the existing ones.
In addition, a new View interface has been added to allow for custom implementations. An example implementation has been included using the https://github.com/charmbracelet/bubbletea library.
Please note that this is a draft, and more changes will be required before this can be merged. Feedback and suggestions are welcome!