Extra exception handling to catch interrupted errors #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vankka
requested changes
Jul 29, 2024
jda4/src/main/java/me/scarsz/jdaappender/ChannelLoggingHandler.java
Outdated
Show resolved
Hide resolved
jda4/src/main/java/me/scarsz/jdaappender/ChannelLoggingHandler.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Henri Schubin <[email protected]>
|
Still doesn't compile on my end but that might be because my dev environment is messed up. |
Vankka
requested changes
Jul 30, 2024
| } | ||
| return currentMessage; |
There was a problem hiding this comment.
Please throw here as it did previously and only return when a interrupt is hit
| } | ||
| return currentMessage; |
There was a problem hiding this comment.
Please throw here as it did previously and only return when a interrupt is hit
granny
suggested changes
Jul 30, 2024
jda4/src/main/java/me/scarsz/jdaappender/ChannelLoggingHandler.java
Outdated
Show resolved
Hide resolved
jda4/src/main/java/me/scarsz/jdaappender/ChannelLoggingHandler.java
Outdated
Show resolved
Hide resolved
jda4/src/main/java/me/scarsz/jdaappender/ChannelLoggingHandler.java
Outdated
Show resolved
Hide resolved
Vankka
approved these changes
Jul 31, 2024
Co-authored-by: granny <[email protected]>
Co-authored-by: granny <[email protected]>
Co-authored-by: granny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.