Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span name attribute and tiktoken mapping for gpt-4o-mini #78

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

rohit-kadhe
Copy link
Contributor

Description

Please include a summary of the changes and the related issue to help is review the PR better and faster.

Checklist for EVERY version bump:

  • Ran generate_python.sh to generate python models. (Check README.md for instructions)
  • Ran generate_typescript.sh to generate typescript models. (Check README.md for instructions)
  • Ran black . to format the python code.
  • Updated version in setup.py for python package.
  • Updated version in package.json for typescript package.
  • Updated the required version of trace-attributes in python SDK dependency project.toml file.
  • Updated the required version of @langtrase/trace-attributes in typescript SDK dependency package.json.

@rohit-kadhe rohit-kadhe force-pushed the rohit/S3EN-2640-add-vendor-attributes branch from 276f240 to c01a2d4 Compare August 1, 2024 22:17
Copy link
Contributor

@karthikscale3 karthikscale3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be regenerating python schema aswell?

@rohit-kadhe rohit-kadhe force-pushed the rohit/S3EN-2640-add-vendor-attributes branch from 90406d8 to 935d8d5 Compare August 8, 2024 16:14
…tes into rohit/S3EN-2640-add-vendor-attributes
@rohit-kadhe rohit-kadhe force-pushed the rohit/S3EN-2640-add-vendor-attributes branch from 935d8d5 to 03f5181 Compare August 8, 2024 16:17
@rohit-kadhe rohit-kadhe merged commit 509900a into main Aug 8, 2024
@rohit-kadhe rohit-kadhe deleted the rohit/S3EN-2640-add-vendor-attributes branch August 8, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants