Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]:- Fixed the mobile view #70

Merged
merged 5 commits into from
May 13, 2024

Conversation

mohit-bhandari45
Copy link
Contributor

fixes #53

Description:- The mobile version of the app was messed up, so I fixed it at every different level of screen size.

Screenshots:-
image
image

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 3:01pm
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 3:01pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @mohit-bhandari45! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

@Satyam1923 Satyam1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-13 024947
it breaks for these values.

@mohit-bhandari45
Copy link
Contributor Author

which one?

@Satyam1923
Copy link
Owner

@mohit-bhandari45 for width 988px

Copy link

vercel bot commented May 13, 2024

@mohit-bhandari45 is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

@mohit-bhandari45
Copy link
Contributor Author

check now

@Satyam1923
Copy link
Owner

Screenshot 2024-05-13 180050
Screenshot 2024-05-13 180107
from from 1470 to 999 ui is broken.

@mohit-bhandari45
Copy link
Contributor Author

Actually it is breaking due to height

@mohit-bhandari45
Copy link
Contributor Author

mohit-bhandari45 commented May 13, 2024

actually some screen sizes doesn't exist, but this is responsive for most of the screen
made some more changes btw

@Satyam1923
Copy link
Owner

fine !

@Satyam1923 Satyam1923 merged commit ceea384 into Satyam1923:master May 13, 2024
3 checks passed
@mohit-bhandari45 mohit-bhandari45 deleted the fix/mobile-version branch May 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: The app is getting break in responsiveness
2 participants